Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds quotes to value containing : in runtime_fields test #63545

Merged
merged 1 commit into from
Oct 12, 2020
Merged

Adds quotes to value containing : in runtime_fields test #63545

merged 1 commit into from
Oct 12, 2020

Conversation

picandocodigo
Copy link
Member

This Pull Request wraps a value containing : in quotes so the YAML parser doesn't error when trying to load this test file.

Also in 7.x: #63543

@picandocodigo picandocodigo added :Core/Infra/REST API REST infrastructure and utilities Team:Clients Meta label for clients team labels Oct 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/REST API)

@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Oct 12, 2020
@picandocodigo picandocodigo mentioned this pull request Oct 12, 2020
Merged
@picandocodigo picandocodigo requested a review from nik9000 October 12, 2020 14:21
@picandocodigo picandocodigo merged commit d98a964 into elastic:master Oct 12, 2020
@picandocodigo picandocodigo deleted the adds_quotes_long_test_master branch October 12, 2020 15:03
@picandocodigo
Copy link
Member Author

Thanks @nik9000!

@picandocodigo picandocodigo mentioned this pull request Oct 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nik9000 nik9000 nik9000 approved these changes

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities Team:Clients Meta label for clients team Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@picandocodigo @elasticmachine @nik9000